gNMI-1.6 fix

[manan-patel]

[gemini-code-assist[bot]]

Summary of Changes

Hello @manan-patel, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a fix for gNMI 1.6, specifically targeting compatibility and testing stability with Cisco devices within the gNMI network instance tests. The changes involve adjusting the test logic to bypass gNMI server configuration for Cisco platforms and removing a previously defined interface deviation, which collectively aim to resolve issues encountered on these devices.

Highlights

• gNMI Server Configuration: The gNMI server configuration step in gnmi_ni_test.go is now conditionally skipped for Cisco devices to prevent potential issues.
• Cisco Platform Deviations: A specific platform exception for Cisco, related to interface_enabled deviations, has been removed from the metadata.textproto file.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[OpenConfigBot]

Pull Request Functional Test Report for #4786 / 46e9e3e15cfab5a33f23fab19318c9b179985961

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		gNMI-1.6: System gRPC Servers running in more than one network-instance
Cisco 8000E		gNMI-1.6: System gRPC Servers running in more than one network-instance
Cisco XRd		gNMI-1.6: System gRPC Servers running in more than one network-instance
Juniper ncPTX		gNMI-1.6: System gRPC Servers running in more than one network-instance
Nokia SR Linux		gNMI-1.6: System gRPC Servers running in more than one network-instance
Openconfig Lemming		gNMI-1.6: System gRPC Servers running in more than one network-instance

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		gNMI-1.6: System gRPC Servers running in more than one network-instance
Cisco 8808		gNMI-1.6: System gRPC Servers running in more than one network-instance
Juniper PTX10008		gNMI-1.6: System gRPC Servers running in more than one network-instance
Nokia 7250 IXR-10e		gNMI-1.6: System gRPC Servers running in more than one network-instance

Help

[coveralls]

Pull Request Test Coverage Report for Build 19554444493

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 24 (0.0%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.007%) to 10.093%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/deviations/deviations.go	0	5	0.0%
proto/metadata_go_proto/metadata.pb.go	0	8	0.0%
internal/cfgplugins/system.go	0	11	0.0%
<!--	Total:	0	24

Totals
Change from base Build 19545469397:	-0.007%
Covered Lines:	2224
Relevant Lines:	22034

---

💛 - Coveralls

[dbarney1106]

This deviation is skipping configuring grpc server in default vrf; this should not be the case.

This should not be the case, if the grpc server is already present (under assumption bootstrap config has it pre-preconfigured) and we are are latter configuring it back, the OC config should not impact the server.

Can we include in this PR changing the base config ?

Also, Are other FNT broken when the base config is changed?

[dbarney1106]

/fptest cisco-8000e