openconfig
Adding encap/decap tunnel interface counters
Pull Request Functional Test Report for #4656 / b0e1ba684902dccef1787b3cc1c6bdec9afd8483
Virtual Devices
| Device | Test | Test Documentation | Job | Raw Log |
|---|---|---|---|---|
| Arista cEOS |  |
TE-16.1: basic encapsulation tests |
386f4c58 | Log |
| Cisco 8000E |  |
TE-16.1: basic encapsulation tests |
6f7269ef | Log |
| Cisco XRd |  |
TE-16.1: basic encapsulation tests |
01aca2dc | Log |
| Juniper ncPTX |  |
TE-16.1: basic encapsulation tests |
04642f64 | Log |
| Nokia SR Linux |  |
TE-16.1: basic encapsulation tests |
1336f015 | Log |
| Openconfig Lemming |  |
TE-16.1: basic encapsulation tests |
b1f57df9 | Log |
Hardware Devices
| Device | Test | Test Documentation | Raw Log |
|---|---|---|---|
| Arista 7808 |  |
TE-16.1: basic encapsulation tests |
|
| Cisco 8808 |  |
TE-16.1: basic encapsulation tests |
|
| Juniper PTX10008 |  |
TE-16.1: basic encapsulation tests |
|
| Nokia 7250 IXR-10e |  |
TE-16.1: basic encapsulation tests |
Pull Request Test Coverage Report for Build 18371850770
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 975 unchanged lines in 7 files lost coverage.
- Overall coverage increased (+0.5%) to 12.283%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| internal/iputil/iputil.go | 3 | 94.12% |
| internal/deviations/deviations.go | 9 | 0.0% |
| internal/cfgplugins/mpls.go | 24 | 0.0% |
| internal/otg_helpers/packetvalidationhelpers/packetvalidationhelpers.go | 31 | 0.0% |
| internal/cfgplugins/qos.go | 66 | 0.0% |
| internal/cfgplugins/policyforwarding.go | 86 | 0.0% |
| proto/metadata_go_proto/metadata.pb.go | 756 | 0.0% |
| <!-- | Total: | 975 |
| Totals | |
|---|---|
| Change from base Build 18146974775: | 0.5% |
| Covered Lines: | 2224 |
| Relevant Lines: | 18107 |
💛 - Coveralls
I still see the tunnel encap counters are present?
This is a gribi focused test for programming the AFT tables. There are some other tests for AFT counters.
The relevant AFT counters paths to interoperate with gRIBI include:
/network-instances/network-instance/afts/ipv4-unicast/ipv4-entry/state/counters/packets-forwarded leaf counter64 openconfig-network-instance /network-instances/network-instance/afts/ipv4-unicast/ipv4-entry/state/counters/octets-forwarded leaf counter64 openconfig-network-instance /network-instances/network-instance/afts/ipv6-unicast/ipv6-entry/state/counters/packets-forwarded leaf counter64 openconfig-network-instance /network-instances/network-instance/afts/ipv6-unicast/ipv6-entry/state/counters/octets-forwarded leaf counter64
openconfig-network-instance /network-instances/network-instance/afts/next-hops/next-hop/state/counters/packets-forwarded leaf counter64 openconfig-network-instance /network-instances/network-instance/afts/next-hops/next-hop/state/counters/octets-forwarded leaf counter64 openconfig-aft-summary /network-instances/network-instance/afts/aft-summaries/ipv4-unicast/protocols/protocol/state/counters/aft-entries leaf uint64 openconfig-aft-summary /network-instances/network-instance/afts/aft-summaries/ipv6-unicast/protocols/protocol/state/counters/aft-entries
For policy-forwarding, some paths include:
openconfig-network-instance /network-instances/network-instance/afts/policy-forwarding/policy-forwarding-entry/state/counters/packets-forwarded leaf counter64 openconfig-network-instance /network-instances/network-instance/afts/policy-forwarding/policy-forwarding-entry/state/counters/octets-forwarded leaf counter64 openconfig-network-instance /network-instances/network-instance/policy-forwarding/policies/policy/rules/rule/state/matched-pkts leaf counter64 openconfig-network-instance /network-instances/network-instance/policy-forwarding/policies/policy/rules/rule/state/matched-octets leaf counter64
Let's discuss offline what the use case is and if this test should be revised, or if some other test already covers the counters or if a new test is needed
- for telematry we shall stream and collect
/network-instances/network-instance/afts/next-hops/next-hop/state/countersfor:- for NH#201 and NH#202. to collect ENCAPSULATION counters and wECMP among tunnels.
- for NH#1, NH#2, NH#10, NH#11, NH100, NH101 to collect wECMP hirearchy
- The Test plan shall explicitly spell-out traffic share hancle aby all this NH. I mean compouded weights.
- Like [NH#10, NH#11, NH100, NH101] = [5:15:24:36]
openconfig-network-instance /network-instances/network-instance/afts/next-hops/next-hop/state/counters/packets-forwarded leaf counter64 openconfig-network-instance /network-instances/network-instance/afts/next-hops/next-hop/state/counters/octets-forwarded leaf counter64
Thanks @rszarecki for that. Ok, so we want some test to cover these counters:
openconfig-network-instance /network-instances/network-instance/afts/next-hops/next-hop/state/counters/packets-forwarded leaf counter64
openconfig-network-instance /network-instances/network-instance/afts/next-hops/next-hop/state/counters/octets-forwarded leaf counter64
Knowing there is some significant variation in support of these gnmi counters, which is quite different than the support for gRIBI programming of next-hops, I recommend a separate README just for the AFT next-hop counters.