featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

Versioning are hardcoded in test.go and credz.go, replaced them with variable

Open asishkbasu opened this issue 10 months ago • 2 comments

credz.go

  • version was hard coded for below 2 functions - modified them to use variable
  • RotateAuthorizedPrincipal
  • RotateTrustedUserCA

password_console_login_test.go:

  • version was hard coded - modified them to use variable to avoid RPC push error (Already_Exists)
  • Telemetry reports host certificate created on validation was not appropriate - fixed the same

host_certificates_test.go:

  • version was hard coded - modified them to use variable to avoid RPC push error (Already_Exists)
  • Telemetry reports host certificate created on validation was not appropriate - fixed the same
  • cmp.Equal function was crashing (panic) while comparing the keys (gotHostKey, wantHostKey) hence used reflect to compare

ssh_public_key_authentication_test.go:

  • version was hard coded - modified them to use variable to avoid RPC push error (Already_Exists)
  • Telemetry reports host certificate created on validation was not appropriate - fixed the same

asishkbasu avatar Apr 01 '25 07:04 asishkbasu

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 01 '25 07:04 google-cla[bot]

Pull Request Functional Test Report for #4096 / 350a2d5e4f4d778ab5de6445e7fe3476e9820889

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
status
status
status
status
Credentialz-3: Host Certificates
Credentialz-1: Password console login
Credentialz-2: SSH Password Login Disallowed
Credentialz-4: SSH Public Key Authentication
Credentialz-5: Hiba Authentication
Cisco 8000E status
status
status
status
status
Credentialz-3: Host Certificates
Credentialz-1: Password console login
Credentialz-2: SSH Password Login Disallowed
Credentialz-4: SSH Public Key Authentication
Credentialz-5: Hiba Authentication
Cisco XRd status
status
status
status
status
Credentialz-3: Host Certificates
Credentialz-1: Password console login
Credentialz-2: SSH Password Login Disallowed
Credentialz-4: SSH Public Key Authentication
Credentialz-5: Hiba Authentication
Juniper ncPTX status
status
status
status
status
Credentialz-3: Host Certificates
Credentialz-1: Password console login
Credentialz-2: SSH Password Login Disallowed
Credentialz-4: SSH Public Key Authentication
Credentialz-5: Hiba Authentication
Nokia SR Linux status
status
status
status
status
Credentialz-3: Host Certificates
Credentialz-1: Password console login
Credentialz-2: SSH Password Login Disallowed
Credentialz-4: SSH Public Key Authentication
Credentialz-5: Hiba Authentication
Openconfig Lemming status
status
status
status
status
Credentialz-3: Host Certificates
Credentialz-1: Password console login
Credentialz-2: SSH Password Login Disallowed
Credentialz-4: SSH Public Key Authentication
Credentialz-5: Hiba Authentication

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
status
status
status
status
Credentialz-3: Host Certificates
Credentialz-1: Password console login
Credentialz-2: SSH Password Login Disallowed
Credentialz-4: SSH Public Key Authentication
Credentialz-5: Hiba Authentication
Cisco 8808 status
status
status
status
status
Credentialz-3: Host Certificates
Credentialz-1: Password console login
Credentialz-2: SSH Password Login Disallowed
Credentialz-4: SSH Public Key Authentication
Credentialz-5: Hiba Authentication
Juniper PTX10008 status
status
status
status
status
Credentialz-3: Host Certificates
Credentialz-1: Password console login
Credentialz-2: SSH Password Login Disallowed
Credentialz-4: SSH Public Key Authentication
Credentialz-5: Hiba Authentication
Nokia 7250 IXR-10e status
status
status
status
status
Credentialz-3: Host Certificates
Credentialz-1: Password console login
Credentialz-2: SSH Password Login Disallowed
Credentialz-4: SSH Public Key Authentication
Credentialz-5: Hiba Authentication

Help

OpenConfigBot avatar Apr 01 '25 07:04 OpenConfigBot

Please fix merge conflicts.

nikki-blr avatar Sep 18 '25 08:09 nikki-blr