RT-1.32: BGP policy actions - MED LocPref changes incorporated

[ampattan]

Updated metadata.textproto

• ExplicitPortSpeed removed.

Updated actions_MED_LocPref_prepend_flow_control_test.go

• The "deleteNbr" detail has been updated for RT-1.32.5 to address an issue where an unintended neighbor was being used for deleting the import and export policy.
• The log messages have been modified to print proper value.
• Skipping local-preference validation on eBGP based on RFC-4271, Section-5.1.5

The new yang changes for BGP MED policy action using updated ondatra

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

[OpenConfigBot]

Pull Request Functional Test Report for #3447 / ecf225528cabbb0b794bd61d1dedbafe5c6ecabd

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Cisco 8000E		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Cisco XRd		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Juniper ncPTX		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Nokia SR Linux		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Openconfig Lemming		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Cisco 8808		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Juniper PTX10008		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
Nokia 7250 IXR-10e		RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control

Help

[dplore]

/fptest virtual

[coveralls]

Pull Request Test Coverage Report for Build 14640996967

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 18.016%

---

Totals
Change from base Build 14634818763:	0.0%
Covered Lines:	2481
Relevant Lines:	13771

---

💛 - Coveralls

[ampattan]

HW log with these changes are available at - b/390080025

[ksgireesha]

@dplore / @nsadhasivam , can you review this please

[ram-mac]

@ampattan - This test is failing for Nokia with error and iam using the right image AFAIK (0.0.1-68451)

Failing to set the TestBGPPolicy/Configure_eBGP_increase_MED_Import_Export_Policy }: Schema '/routing-policy/policy-definitions/policy-definition/statements/statement/actions/bgp-actions/config' has no local leaf with the name 'set-med-action'. Options are [set-route-origin, set-local-pref, set-next-hop, set-med]: Parse error on line 18: "set-med": 100, Input: '{ "openconfig-routing-policy:policy-definitions": { "policy-definition": [ { "config": { "name": "med-policy" }, "name": "med-policy", "statements": { "statement": [ { "actions": { "config": { "policy-result": "ACCEPT_ROUTE" }, "openconfig-bgp-policy:bgp-actions": { "config": { "set-med": 100, ...' === RUN TestBGPPolicy/Configure_eBGP_set_NEXT-STATEMENT_Import_Export_Policy

    }: Schema '/routing-policy/policy-definitions/policy-definition/statements/statement/actions/bgp-actions/config' has no local leaf with the name 'set-med-action'. Options are [set-route-origin, set-local-pref, set-next-hop, set-med]: Parse error on line 18:                     "set-med": 70,
    Input:
    '{
      "openconfig-routing-policy:policy-definitions": {
        "policy-definition": [
          {
            "config": {
              "name": "flow-control-policy"
            },
            "name": "flow-control-policy",
            "statements": {
              "statement": [
                {
                  "actions": {
                    "config": {
                      "policy-result": "NEXT_STATEMENT"
                    },
                    "openconfig-bgp-policy:bgp-actions": {
                      "config": {
                        "set-med": 70,
     ...'

=== RUN TestBGPPolicy/Configure_eBGP__prepend_10_x_local_ASN_Import_Export_Policy

[ram-mac]

--- FAIL: TestBGPPolicy (215.14s) --- PASS: TestBGPPolicy/Configure_OTG (98.26s) --- PASS: TestBGPPolicy/Configure_DUT_interfaces (3.86s) --- PASS: TestBGPPolicy/Configure_DEFAULT_network_instance (0.65s) --- PASS: TestBGPPolicy/Configure_BGP_v4_and_v6_Neighbors (2.14s) --- PASS: TestBGPPolicy/Verify_port_status_on_DUT (1.24s) --- PASS: TestBGPPolicy/Verify_BGP_session (33.30s) --- FAIL: TestBGPPolicy/Configure_eBGP_set_MED_Import_Export_Policy (1.28s) --- FAIL: TestBGPPolicy/Configure_eBGP_increase_MED_Import_Export_Policy (1.27s) --- PASS: TestBGPPolicy/Configure_iBGP_set_Local_Preference_Import_Export_Policy (24.70s) --- FAIL: TestBGPPolicy/Configure_eBGP_set_NEXT-STATEMENT_Import_Export_Policy (1.37s) --- PASS: TestBGPPolicy/Configure_eBGP__prepend_10_x_local_ASN_Import_Export_Policy (23.35s) --- PASS: TestBGPPolicy/Configure_eBGP__prepend_10_x_ASN_Import_Export_Policy (23.73s)

[ram-mac]

@ampattan - as discussed, iam assigning back the PR to you since this is currently not verifiable on the DCGate image that we have. Once the PR is ready to validate, flip it back to me.

[ampattan]

BgpSetMedActionUnsupported deviation has been introduced to accommodate set-med action changes.

Please refer the discussion https://github.com/openconfig/featureprofiles/pull/3505#discussion_r1935943613

[ram-mac]

@ampattan - Static analysis are failing - can u please fix them and assign back.

[ampattan]

@ampattan - Static analysis are failing - can u please fix them and assign back.

removed unused function.