featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

Updates to Transceiver-12: zr_supply_voltage_test

Open hattikals opened this issue 1 year ago • 4 comments

  • Added the function configureInterface to configure the interface with required targetOutputPower and frequency.
  • Added functions opticalChannelComponentFromPort and isSubCompOfHardwarePort to get optical_comp name from port.
  • Changed the path to opticalComp to verify frequency and targetOutputPower , as they come under OpticalChannel , optical comp name has to be passed
  • Added the code to flap the interface as it was missing and code was waiting for interface to go down without any changes.

hattikals avatar Apr 12 '24 17:04 hattikals

Pull Request Test Coverage Report for Build 8763230612

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.448%

Totals Coverage Status
Change from base Build 8668701483: 0.0%
Covered Lines: 1949
Relevant Lines: 3515

💛 - Coveralls

coveralls avatar Apr 12 '24 17:04 coveralls

opticalChannelComponentFromPort should be moved into /internal. Please coordinate with @prinikasn and see https://github.com/openconfig/featureprofiles/pull/2890#discussion_r1561822628

dplore avatar Apr 13 '24 01:04 dplore

@dplore and @prinikasn I have moved the common functions to cfgplugins as per comment given on #2890 . Please check.

hattikals avatar Apr 20 '24 06:04 hattikals

Closing this as recent merge to the test had similar changes.

hattikals avatar Sep 30 '24 06:09 hattikals