SAI icon indicating copy to clipboard operation
SAI copied to clipboard

Add a RIF attribute to specify if the corresponding My MAC entry should not be created..

Open erohsik opened this issue 1 year ago • 6 comments

Add an attribute used to specify if My MAC entry need not be created for this {port, vlan, MAC address}.

erohsik avatar May 29 '24 17:05 erohsik

@itaibaz I believe you had commented during the call.. Does this sound reasonable?

/**
 * @brief Attribute used to specify external My MAC entry that will
 * be used in place of any implicit entry created during RIF processing
 * for this {port, vlan, MAC address}
 *
 * @type sai_object_id_t
 * @flags CREATE_ONLY
 * @objects SAI_OBJECT_TYPE_MY_MAC
 * @allownull true
 * @default SAI_NULL_OBJECT_ID
 */
SAI_ROUTER_INTERFACE_ATTR_MY_MAC,

erohsik avatar Jul 02 '24 03:07 erohsik

Hi, the comment must have been from someone else, not me

itaibaz avatar Jul 02 '24 03:07 itaibaz

@itaibaz, @rck-innovium, @JaiOCP - could you please help review?

tjchadaga avatar Oct 04 '24 23:10 tjchadaga

@erohsik - please help resolve conflicts on the branch

tjchadaga avatar Oct 24 '24 17:10 tjchadaga

@erohsik - please help resolve conflicts on the branch

Done...

erohsik avatar Nov 07 '24 05:11 erohsik

@rck-innovium, @JaiOCP - could you please help sign-off?

tjchadaga avatar Nov 13 '24 23:11 tjchadaga

@rck-innovium, @JaiOCP - could you please help sign-off?

Can you please review? Thanks!

erohsik avatar Apr 04 '25 17:04 erohsik

/azp run

erohsik avatar Apr 08 '25 15:04 erohsik

Commenter does not have sufficient privileges for PR 2021 in repo opencomputeproject/SAI

azure-pipelines[bot] avatar Apr 08 '25 15:04 azure-pipelines[bot]

Please update the comments as discussed.

Thanks.. Updated the comments.. please take a look.

erohsik avatar Apr 08 '25 16:04 erohsik

/azp run

tjchadaga avatar Apr 08 '25 18:04 tjchadaga

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 08 '25 18:04 azure-pipelines[bot]

/azp run

tjchadaga avatar Apr 10 '25 16:04 tjchadaga

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 10 '25 16:04 azure-pipelines[bot]

please fix errors, your brief message is too long

kcudnik avatar Apr 11 '25 07:04 kcudnik

/azp run

tjchadaga avatar Apr 14 '25 21:04 tjchadaga

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 14 '25 21:04 azure-pipelines[bot]