opencomputeproject
Src fdb meta data
Failures are of the following form:
ERROR: check ! SAI_ACL_TABLE_ATTR_FIELD_ROUTE_NPU_META_DST_HIT value is 0x0000115b, but on was 0x00001044 on commit 3132018
However, even before this change, value of SAI_ACL_TABLE_ATTR_FIELD_ROUTE_NPU_META_DST_HIT is 0x104c and not 0x1044 as the log above suggests. Reference: https://github.com/opencomputeproject/SAI/blob/master/inc/saiacl.h#L1307
Thus, am not sure if the check is honoring the enum value set in the sources. @kcudnik thoughts on what might be missing?
Failures are of the following form:
ERROR: check ! SAI_ACL_TABLE_ATTR_FIELD_ROUTE_NPU_META_DST_HIT value is 0x0000115b, but on was 0x00001044 on commit 3132018
However, even before this change, value of SAI_ACL_TABLE_ATTR_FIELD_ROUTE_NPU_META_DST_HIT is 0x104c and not 0x1044 as the log above suggests. Reference: https://github.com/opencomputeproject/SAI/blob/master/inc/saiacl.h#L1307
Thus, am not sure if the check is honoring the enum value set in the sources. @kcudnik thoughts on what might be missing?
yea, seems like value is 0x104c, probably there is a bug in parsing logic that incorrectly calculates value for SAI_ACL_TABLE_ATTR_FIELD_ROUTE_NPU_META_DST_HIT, i will take a look into that
ok, i got this, error is related to this commit: https://github.com/opencomputeproject/SAI/pull/1398/commits/97fb4df895e0c33bd955c6dd5117d8c97c76e345
which is first commit you made, and it's specifies this :
SAI_ACL_TABLE_ATTR_FIELD_FDB_SRC_USER_META = SAI_ACL_TABLE_ATTR_FIELD_START + 0x15b,
and for this logic value will be 0x0000115b, and logs are also specifying this error for this specific commit:
processing commit 97fb4df
ERROR: check ! SAI_ACL_TABLE_ATTR_FIELD_ROUTE_NPU_META_DST_HIT value is 0x0000115b, but on was 0x00001044 on commit 3132018
unfortunately current ancestry logic is checking each commit separately (in case you want to rebase instead of squash commits in PR) and everything must be consistent and values can't change between commits, so to fix this you will need to force push this PR with squashed commits to final form, or the one that don't change
plus, you will need to fix SAI_ACL_TABLE_ATTR_FIELD_SRC_IPV6_ shift, and SWITCH_ATTR shift