SAI icon indicating copy to clipboard operation
SAI copied to clipboard

make test fails. Is sai_switch_notification_t deprecated or missing?

Open ncalad opened this issue 4 years ago • 1 comments

When running make test, I encounter a build error because sai_switch_notification_t seems to be missing.

./basic_router.cpp:76:1: error: ‘sai_switch_notification_t’ does not name a type; did you mean ‘sai_switch_stat_t’? 76 | sai_switch_notification_t plat_switch_notification_handlers = | ^~~~~~~~~~~~~~~~~~~~~~~~~ | sai_switch_stat_t ./basic_router.cpp: In function ‘const char* test_profile_get_value(sai_switch_profile_id_t, const char*)’: ./basic_router.cpp:93:28: warning: statement has no effect [-Wunused-value] 57 | #define UNREFERENCED_PARAMETER(P) (P)

ncalad avatar Jul 07 '21 19:07 ncalad

It was updated and changed to sai_switch_notifications_t, i think nobody right now actively monitor "test" directory, it's probably out of date. If you are interested in tests, could you make a PR fix for this?

kcudnik avatar Jul 07 '21 20:07 kcudnik