OpenNetworkLinux
OpenNetworkLinux copied to clipboard
Gap between onlp_led_caps_e and onlp_led_mode_e in led.h
packages/base/any/onlp/src/onlp/module/inc/onlp/led.h
typedef enum onlp_led_caps_e {
ONLP_LED_CAPS_ON_OFF = (1 << 0),
ONLP_LED_CAPS_CHAR = (1 << 1),
ONLP_LED_CAPS_RED = (1 << 10),
ONLP_LED_CAPS_RED_BLINKING = (1 << 11),
ONLP_LED_CAPS_ORANGE = (1 << 12),
ONLP_LED_CAPS_ORANGE_BLINKING = (1 << 13),
ONLP_LED_CAPS_YELLOW = (1 << 14),
ONLP_LED_CAPS_YELLOW_BLINKING = (1 << 15),
ONLP_LED_CAPS_GREEN = (1 << 16),
ONLP_LED_CAPS_GREEN_BLINKING = (1 << 17),
ONLP_LED_CAPS_BLUE = (1 << 18),
ONLP_LED_CAPS_BLUE_BLINKING = (1 << 19),
ONLP_LED_CAPS_PURPLE = (1 << 20),
ONLP_LED_CAPS_PURPLE_BLINKING = (1 << 21),
ONLP_LED_CAPS_AUTO = (1 << 22),
ONLP_LED_CAPS_AUTO_BLINKING = (1 << 23),
} onlp_led_caps_t;
typedef enum onlp_led_mode_e {
ONLP_LED_MODE_OFF,
ONLP_LED_MODE_ON,
ONLP_LED_MODE_BLINKING,
ONLP_LED_MODE_RED = 10,
ONLP_LED_MODE_RED_BLINKING = 11,
ONLP_LED_MODE_ORANGE = 12,
ONLP_LED_MODE_ORANGE_BLINKING = 13,
ONLP_LED_MODE_YELLOW = 14,
ONLP_LED_MODE_YELLOW_BLINKING = 15,
ONLP_LED_MODE_GREEN = 16,
ONLP_LED_MODE_GREEN_BLINKING = 17,
ONLP_LED_MODE_BLUE = 18,
ONLP_LED_MODE_BLUE_BLINKING = 19,
ONLP_LED_MODE_PURPLE = 20,
ONLP_LED_MODE_PURPLE_BLINKING = 21,
ONLP_LED_MODE_AUTO = 22,
ONLP_LED_MODE_AUTO_BLINKING = 23,
} onlp_led_mode_t;
There is no BLINKING in the caps enum. And actually our product has yellow and green blinking alternately by 1Hz and 4Hz which mean minor and major alarm. Could anyone check with this issue?
ONLP_LED_CAPS_YELLOW_GREEN_BLINKING = (1 << 24)
ONLP_LED_CAPS_YELLOW_GREEN_BLINKING = (1 << 24)
Yes, I can add them in the struct. But it is common code I want the community to check it first :)