errors from storage-adapters being ignored

[kmcrawford]

This issue effects if there is an error from a storage adapter

This non-caching of errors has kept a polling issue aloof. And could be causing other issue.

When does this occur?

This occurs when the getFromJson is called, there is an error object being returned that is not being acted on.

https://github.com/opencomponents/oc/blob/bd5bc06b4c42a9588177f92ced1ab5f1084a1189/src/registry/domain/components-details.js#L66

Where on the platform does it happen?

I have proved this issue by forking the storage-adapter and adding logging where there is an error. I can see in the logs that occasionally an error is being thrown and not acted on or logged.

Expected behavior (i.e. solution)

I would expect if a storage-adapter throws a error it would be logged and acted upon.

What version of OC, Node.js and OS are you using?

Latest.

Other Comments

Another issue will be submitted for the issue found with the oc-gs-storage-adapter