linux icon indicating copy to clipboard operation
linux copied to clipboard

Describe upstream regulators for Witherspoon's BMP280

Open amboar opened this issue 6 years ago • 6 comments

Currently the following warnings are issued for Witherspoon's devicetree:

arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dt.yaml: bmp280@77: 'vddd-supply' is a required property
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dt.yaml: bmp280@77: 'vdda-supply' is a required property

amboar avatar Jul 23 '19 06:07 amboar

FYI, that device only existed on some early lab versions of that system, and didn't ship to the field.

spinler avatar Jul 23 '19 13:07 spinler

Can we drop it from the devicetree then?

amboar avatar Jul 24 '19 02:07 amboar

@amboar, I'd prefer that it does not get dropped as that would then cause these lab systems still in use to no longer have an available ambient sensor.

msbarth avatar Jul 24 '19 14:07 msbarth

Not that I am a kernel guru or anything, but BMP280 issue caught my eye.

I was curious what those were, and why they would be required.

Is it just me, or did those start out as optional and move to required? https://patchwork.ozlabs.org/patch/637124/

bjwyman avatar Jul 25 '19 21:07 bjwyman

@bjwyman hah! Indeed they did, but not in the change you pointed to, but rather this one:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.3-rc2&id=88aa7ae661284accd4c058429d6d0a3b7397e081

This was introduced in v5.2. I'll poke people.

amboar avatar Jul 30 '19 03:07 amboar

Okay, I was just noting that going back to the patch I mentioned, those appeared to be optional, but somehow they later ended up as required. The change you pointed to is obviously where that was introduced.

bjwyman avatar Jul 30 '19 21:07 bjwyman