openapi-python-client icon indicating copy to clipboard operation
openapi-python-client copied to clipboard

Ignore Content-Type parameters

Open dbanty opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? Please describe.

RFC2616 allows parameters to content-types, for example application/json; version=2.3.5 is a valid content type that should be treated like application/json. Currently this is not supported by this project.

Describe the solution you'd like

Ignore any parameters (things including and after ;) in the content type.

Describe alternatives you've considered

Using #657.

Additional context

https://github.com/openapi-generators/openapi-python-client/discussions/655

dbanty avatar Aug 21 '22 17:08 dbanty

On another thought, can the parameters be used as a discriminator? I mean is it valid OpenAPI with multiple responses for the same path, method and content type differing only with a parameter?

path:
   /path:
      get:
        responses:
          '200':
            content:
              application/json; version=2.3.5:
                schema:
                  $ref: '#/components/schemas/Model23'
              application/json; version=2.4.0:
                schema:
                  $ref: '#/components/schemas/Model24'

I guess the parameters should only be ignored only when selecting a decoder, and even then, maybe use the encoding param

rafalkrupinski avatar Aug 22 '22 06:08 rafalkrupinski