shinyproxy-config-examples icon indicating copy to clipboard operation
shinyproxy-config-examples copied to clipboard

Simplify example for `02-containerized-docker-engine`

Open ALanguillaume opened this issue 1 year ago • 2 comments

Hoi @openanalytics !

Thanks for this great tool.

I was skimming through the documentation for 02-containerized-docker-engine and I am wondering if the example could be simplified or not.

I tend to use directly your openanalytics/shinyproxy image and mount the application.yml as a volume in the docker run or compose command as such:

docker run \
-v /var/run/docker.sock:/var/run/docker.sock:ro \
-v ./application.yml:/opt/shinyproxy/application.yml \
--group-add $(getent group docker | cut -d: -f3) \
--net sp-example-net \
-p 8080:8080 \
openanalytics/shinyproxy:3.1.0

Any reason not to implement this as the example ?

Is it only for didactic reasons or am I missing nothing ?

ALanguillaume avatar Jun 03 '24 15:06 ALanguillaume

Hi, thanks for opening this issue. There is no specific reason for this, but I guess the original idea was to demonstrate how people could customize the image. Since mounting the config file reduces the number of steps, I'll update the example to use this approach.

LEDfan avatar Jun 13 '24 12:06 LEDfan

Happy days ! Thanks for your reply

ALanguillaume avatar Jun 13 '24 12:06 ALanguillaume