feat(auth): changed authentication to urlencoded.

[Abhirup-99]

Description

changed authentication to urlencoded. Fixes #1241

Related issues and discussion

#1241

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• [x] If you have multiple commits please combine them into one commit by squashing them.

• [x] Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

[Abhirup-99]

@karantakalkar can you review this?

[Abhirup-99]

This looks about right to me, but I have not tested this.

An active maintainer of the web-app repo should also peer review, and merge, if OK.

can you give me the URL and some demo credentials to test it out? @vorburger

[vorburger]

can you give me the URL and some demo credentials to test it out? @vorburger

There's no server with OAuth (that I know of); https://www.fineract.dev does not have OAuth enabled.

But https://github.com/apache/fineract/blob/develop/docs/deployment/oauth.md explains how to set it up locally.

Background re this change is in https://issues.apache.org/jira/browse/FINERACT-629.

[Abhirup-99]

I am not very familiar with Java, can you pull it and test it locally. Sorry can't help with this.

[Abhirup-99]

These changes seem fine to me, but shouldn't

https://github.com/openMF/web-app/blob/543e51c1657cb2d411c034c1f8d31c178418d566/src/app/core/authentication/authentication.service.ts#L151

be also changed similarly?, I'll test localy and merge in a while, have been busy with semester work lately.

Yes I guess so, should I change this as well? Also, please don't merge this until it's tested. I am not able to test this locally, so can't vouch on the results.

[Abhirup-99]

can you give me the URL and some demo credentials to test it out? @vorburger

There's no server with OAuth (that I know of); https://www.fineract.dev does not have OAuth enabled.

But https://github.com/apache/fineract/blob/develop/docs/deployment/oauth.md explains how to set it up locally.

Background re this change is in https://issues.apache.org/jira/browse/FINERACT-629.

@vorburger the link for the setup of OAuth locally is broken, can you share the updated link. Thanks in advance.

[vorburger]

@vorburger the link for the setup of OAuth locally is broken, can you share the updated link. Thanks in advance.

https://github.com/apache/fineract/blob/develop/fineract-doc/src/docs/en/03_oauth.adoc

[github-actions[bot]]

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.