web-app icon indicating copy to clipboard operation
web-app copied to clipboard
verified publisher icon openMF

Client charges subsection needs to be improved

Open karantakalkar opened this issue 5 years ago • 10 comments

Code, functionality as well as Routing needs to be made consistent with rest of the app.

Screenshot from 2020-08-28 14-59-51

Access charges subsection on clients view page. https://demo.mifos.io/#/viewclient/1

Screenshot from 2020-09-18 11-19-18

karantakalkar avatar Aug 28 '20 09:08 karantakalkar

Can I look into this issue? I have sent a PR for #746

shobhi1310 avatar Sep 15 '20 13:09 shobhi1310

Go ahead

karantakalkar avatar Sep 15 '20 13:09 karantakalkar

Can the issue be elaborated, like which component is it referring to where consistency is needed and what is this page ?

shobhi1310 avatar Sep 16 '20 16:09 shobhi1310

See implementations of tables/forms/dialogs etc in rest of institution section (clients/groups/centers and sub-modules) and make it similar, charges can be accessed in a table, you can find relevant data on demo or staging servers as dev is not that populated. In case this still seems intricate gain experience with app by contributing to good first issues or report your own issues and submit fix PRs.

karantakalkar avatar Sep 17 '20 08:09 karantakalkar

image This page is navigable through the Institution->Clients

How to reach to the page shown in the screenshot of the issue?

shobhi1310 avatar Sep 17 '20 16:09 shobhi1310

Issue updated

karantakalkar avatar Sep 18 '20 05:09 karantakalkar

@karantakalkar Can I work on this?

BLasan avatar Oct 03 '20 06:10 BLasan

Go Ahead

karantakalkar avatar Oct 03 '20 11:10 karantakalkar

Go Ahead

What are the changes we have to do? It's working fine btw

BLasan avatar Oct 03 '20 15:10 BLasan

@karantakalkar Please review

BLasan avatar Oct 18 '20 17:10 BLasan