android-client icon indicating copy to clipboard operation
android-client copied to clipboard

Fixes #1854 CENTER, CHARGE and CLIENT data manager converted to kotlin. Includes minor fixes

Open danishjamal104 opened this issue 4 years ago • 1 comments

Fixes #1854

This PR includes dependency version update for mockito, 'org.mockito:mockito-core:1.10.19' >> testImplementation 'org.mockito:mockito-core:3.10.0'. Since older version of mockito doesn't support mocking the closed class and by default all Kotlin classes are closed, hence this upgrade has been done.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [x] Apply the MifosStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

danishjamal104 avatar Sep 17 '21 06:09 danishjamal104

@iamsh4shank, @Grandolf49 please review and merge this. Thanks

danishjamal104 avatar Sep 17 '21 08:09 danishjamal104

We're closing this PR since it's already fixed

Aditya-gupta99 avatar Jul 14 '23 19:07 Aditya-gupta99