android-client icon indicating copy to clipboard operation
android-client copied to clipboard

Fixes #1854 Search, Notes and staff data manager converted to kotlin

Open danishjamal104 opened this issue 4 years ago • 4 comments

Fixes #1854

Search data manager is not migrated to Kotlin, due to SearchPresenterTest failure. The reason for the failure of test is because mockito version 1 was not capable of mocking closed classes and in Kotlin by default all classes are closed. This issue will be resolved in subsequent PR.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [x] Apply the MifosStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

danishjamal104 avatar Sep 15 '21 17:09 danishjamal104

@iamsh4shank, @Grandolf49, @luckyman20 please review and merge this. Thanks

danishjamal104 avatar Sep 16 '21 17:09 danishjamal104

@danishjamal104 I am not in touch with this project so I won't be able to review it.

Also, your build is failing so you might be interested in taking a look at that.

luckyman20 avatar Sep 17 '21 04:09 luckyman20

@danishjamal104 I am not in touch with this project so I won't be able to review it.

Also, your build is failing so you might be interested in taking a look at that.

the build is failing because, it is not able to GET pad/checkstyle dependency, which is causing most of the checks to fail. @iamsh4shank must be aware about it.

danishjamal104 avatar Sep 17 '21 08:09 danishjamal104

@danishjamal104 I am not in touch with this project so I won't be able to review it. Also, your build is failing so you might be interested in taking a look at that.

the build is failing because, it is not able to GET pad/checkstyle dependency, which is causing most of the checks to fail. @iamsh4shank must be aware about it.

Yeah there is some issue with PMD plugin

iamsh4shank avatar Sep 17 '21 16:09 iamsh4shank

We're closing this PR since it's already fixed

Aditya-gupta99 avatar Jul 14 '23 19:07 Aditya-gupta99