cooler icon indicating copy to clipboard operation
cooler copied to clipboard

balance_cooler allows store_name even when store=False

Open gfudenberg opened this issue 5 years ago • 1 comments

Should this raise an error? https://github.com/mirnylab/cooler/blob/c9c718fdebccbda41ad10c47f700853f79ee3cd3/cooler/balance.py#L271

gfudenberg avatar Jun 07 '20 01:06 gfudenberg

I'm okay with this. It provides an explicit default. The alternative would be to have a hybrid store argument that takes a bool or a string. store=True would use an implicit default name of "weight" and store={name} would use the provided name.

nvictus avatar Jun 30 '20 16:06 nvictus