opentelemetry-python icon indicating copy to clipboard operation
opentelemetry-python copied to clipboard

Update tracecontext tests

Open xrmx opened this issue 1 year ago • 3 comments

Describe your environment

OS: (e.g, Ubuntu) Python version: (e.g., Python 3.8.10) SDK version: (e.g., 1.25.0) API version: (e.g., 1.25.0)

What happened?

Tracecontext tests have the following warning and we are using a version from 2019. It would be nice to try to update it to a more recent version to avoid warnings and get other improvements done over the years.

opentelemetry-python/target/trace-context/test/tracecontext/tracestate.py:68: SyntaxWarning: "is" with a literal. Did you mean "=="?

Steps to Reproduce

tracecontext job in CI, see scripts/tracecontext-integration-test.sh

Expected Result

No warning

Actual Result

A warning

Additional context

No response

Would you like to implement a fix?

No

xrmx avatar Aug 03 '24 15:08 xrmx

hey @xrmx I'd like to take this task as my starting point of opentelemetry to see if I can upgrade a relatively latest version, could you please guide me how can i start 127.0.0.1:5000 service so I can run scripts/tracecontext-integration-test.sh? thanks in advance

FraserYu avatar Aug 05 '24 14:08 FraserYu

Hi @xrmx Can I work on this ?

Ali-Alnosairi avatar Sep 09 '24 22:09 Ali-Alnosairi

could you please guide me how can i start 127.0.0.1:5000 service so I can run scripts/tracecontext-integration-test.sh? thanks in advance

+1

the test failed : Cannot connect to host 127.0.0.1:5000 ssl:default [Connect call failed ('127.0.0.1', 5000)]

Ali-Alnosairi avatar Sep 12 '24 20:09 Ali-Alnosairi