Bug fix

Open arunk1988 opened this issue 1 year ago • 4 comments

Description

Fixes #4070

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] tox -f py38-sdk

Does This PR Require a Contrib Repo Change?

[ ] Yes. - Link to PR:
[ ] No.

Checklist:

[ ] Followed the style guidelines of this project
[ ] Changelogs have been updated
[ ] Unit tests have been added
[ ] Documentation has been updated

Jul 31 '24 14:07 arunk1988

This is not a fix, this is a workaround to avoid the error.

Jul 31 '24 15:07 xrmx

sorry if i misunderstood, i thought we would see this error if the condition with the loop (if args[0] <= 0) is not met, so initialized the list before the loop

Jul 31 '24 15:07 arunk1988

Yeah but the problem is that we expect to go into that loop, the problem to solve is finding out why we don't

Jul 31 '24 15:07 xrmx

okay..would it be the right approach to assert that at least one call in mock_wait_calls where args[0] is less than or equal to zero ?

Aug 01 '24 03:08 arunk1988