opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard
verified publisher icon open-telemetry

Fix python path to support both windows and linux

Open liad-miggo opened this issue 2 years ago • 3 comments

Description

The library had a bug regarding the execution of the python path in windows context. When there trying to execute a python executable containing a space character in the path it actually tried to execute just the first path. i.e 'C:\Program Files\Python311' there is a space the in program files, tried to execute C:\Program.exe and use the rest as arguments.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • [x] Tested against both windows and linux operating systems.

Does This PR Require a Core Repo Change?

  • [x] No.

liad-miggo avatar Jun 08 '23 14:06 liad-miggo

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: liad-miggo / name: liad eliyahu (49d5d63a6ec69b84ab0c9ac8f1df8965c2bd02b6, 7d964e0bbd5c729cef9ca73bbb06cb66b223ad5c)

linux-foundation-easycla[bot] avatar Jun 08 '23 14:06 linux-foundation-easycla[bot]

Some of the tests failed

shalevr avatar Jun 14 '23 08:06 shalevr

Yeah I saw that, gonna fix it soon On Wed, 14 Jun 2023 at 11:58 Shalev Roda @.***> wrote:

Some of the tests failed

— Reply to this email directly, view it on GitHub https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1838#issuecomment-1590778468, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAKVPBV5JBMBB7FPD5OOOMTXLF4M7ANCNFSM6AAAAAAY7NNJ2A . You are receiving this because you were mentioned.Message ID: @.*** com>

liad-miggo avatar Jun 14 '23 17:06 liad-miggo