opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

[BugFix] Close issue #1195, "Invalid type Exchange for attribute value. Expected one of bool, str, bytes, int, float or a sequence of those types" warning when Celery task runs another celery task

Open Heatstealer opened this issue 3 years ago • 7 comments

Description

There are a lot of serialization errors when celery task run another celery task in case when you are using custom Exchange and custom Queue. Span tags could be only bool, str, bytes, int, float.

Fixes #https://github.com/open-telemetry/opentelemetry-python-contrib/issues/1195

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested on the environment where issue had happened. Added unit test

Does This PR Require a Core Repo Change?

  • [ ] Yes. - Link to PR:
  • [x] No.

Checklist:

  • [x] Followed the style guidelines of this project
  • [x] Changelogs have been updated
  • [x] Unit tests have been added
  • [ ] Documentation has been updated

Heatstealer avatar Jul 18 '22 13:07 Heatstealer

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Heatstealer (b230ecd2e83e80ca4aafef36c59c25e5612a3e7a)
  • :white_check_mark: login: srikanthccv / name: Srikanth Chekuri (f5b272ff51fac22cc53a1bbffd5a1b4896301f69)
  • :white_check_mark: login: tammy-baylis-swi / name: Tammy Baylis (2c3828ea9a597595f4d9d710f45e4fad46a006f0)

Also, please sign the CLA :v:

ocelotl avatar Jul 18 '22 17:07 ocelotl

@Heatstealer Are you still working on this?

lzchen avatar Sep 20 '22 16:09 lzchen

Hello guys, I'm really sorry for so late response. But I'm working for a young corporate and I'd resend CLA agreement to the lawers. I'm pushing them, but I've to get a permission at first. Please understand, it's 1st time that we're faced with that kind of document.

Heatstealer avatar Sep 20 '22 17:09 Heatstealer

@Heatstealer ping, please sign the CLA and add the CHANGELOG entry.

srikanthccv avatar Feb 04 '23 19:02 srikanthccv

Added unit test, updated changelogs, added comments for fix.

Heatstealer avatar Mar 02 '23 15:03 Heatstealer

Thanks for the fix! We need at least one test case that proves this fix does its intended purpose.

@ocelotl Are all the requirements met?

poofeg avatar Jul 12 '23 09:07 poofeg