opentelemetry-php icon indicating copy to clipboard operation
opentelemetry-php copied to clipboard

[contrib] Laravel v1.0 feature freeze 🧊

Open ChrisLightfootWild opened this issue 1 year ago • 2 comments

Intro

Given that Laravel instrumentation reached v1.0, I am proposing that we do a temporary feature freeze while we move towards v1.1 (which is currently under development in https://github.com/open-telemetry/opentelemetry-php-contrib/pull/269).

Package Support Policy

v1.0 supports PHP ^8.0 and Laravel framework versions 6.x - 11.x).

At the time of writing, the current Laravel support policy looks like this:

image

Therefore, I aim to align v1.1 with PHP ^8.1 and framework version 10+11 (12 could probably be added closer to general availability).

Current Refactoring

  • moving towards using SPI and providing support for file-based configuration
    • this is the first package in contrib that is using SPI, so is something of a guinea-pig
    • removes the hard dependency on ext-opentelemetry. This can improve local developer experience for those of us that are working on a project with this dependency but no interest in having to install the PHP otel extension
    • may need to reconsider how to handle this if there are complaints of the instrumentation not working

Known Blockers

  • https://github.com/open-telemetry/opentelemetry-php/issues/1411
    • Discussed approach at SIG. Aim to prevent auto-instrumentation of CLI scripts by default to prevent the commands being hooked and creating very large spans

The Future

There is no defined roadmap per se, so contributors are encouraged to submit ideas as new issues and/or submit their PRs :angel:

I would like to further explore use of file-based configuration, with potential to defer concerns to other packages in the ecosystem (for example, logs via Psr3 instrumentation when available).


Thank you for your patience during this transition.

ChrisLightfootWild avatar Oct 30 '24 22:10 ChrisLightfootWild

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 05:04 stale[bot]

Still planned to continue on with this.

ChrisLightfootWild avatar Apr 28 '25 10:04 ChrisLightfootWild

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 19 '25 05:07 stale[bot]

This issue has been automatically closed because it has not had recent activity, but it can be reopened. Thank you for your contributions.

stale[bot] avatar Oct 18 '25 05:10 stale[bot]