opentelemetry-java-instrumentation icon indicating copy to clipboard operation
opentelemetry-java-instrumentation copied to clipboard

Add support for apache nifi integration

Open bputt-e opened this issue 3 years ago • 17 comments

Is your feature request related to a problem? Please describe. We're looking to add tracing to Apache NiFi and are weighing options of adding an otel implementation within NiFi or seeing if auto instrumentation is more feasible

Describe the solution you'd like Apache NiFi uses spring under the hood, ideally this adds some additional implementation that supports NiFi

Describe alternatives you've considered We're investigating this as an option vs adding manual instrumentation into Apache NiFi

Additional context Apache NiFi can become a little complex...Given the most basic example, imagine if you had two files come in, both files have different traceIds. We decide to merge those files into a single file, what traceId/parentId gets set to the single file?

bputt-e avatar May 25 '22 03:05 bputt-e

hi @bputt-e! if you are able to drop by the OpenTelemetry Java meeting tomorrow at 9am Pacific (and there's also a meeting at 6pm Pacific) that would be a great time to chat through options https://calendar.google.com/calendar/u/0/embed?src=google.com_b79e3e90j7bbsa2n2p5an5lf60@group.calendar.google.com

or if you can describe your initial thoughts/ideas here we can try to provide some pointers/guidance

trask avatar May 25 '22 19:05 trask

@trask I will come to your 6pm Pacific meeting on June 2

bputt-e avatar May 26 '22 20:05 bputt-e

hey @bputt-e! just doing some issue triage, how's this going? thx

trask avatar Aug 15 '23 03:08 trask

hello @trask it's going well, we created a proof of concept originally w/ byte buddy and are now migrating it to the java-instrumentation code base, hoping to submit a pr in the next ~4 weeks

bputt-e avatar Aug 15 '23 11:08 bputt-e

@trask would you or other contributors be able to support a call to go over our instrumentation to help answer some issues we're running into during the build? we could present it at next thursday's meeting, but figured it'd take up too much of the meeting

bputt-e avatar Aug 17 '23 21:08 bputt-e

Hey @bputt-e , This kind of thing is exactly what the SIG meeting is supposed to be used for -- don't worry about taking up too much time, go ahead and join the Thu meeting.

mateuszrzeszutek avatar Aug 18 '23 07:08 mateuszrzeszutek

I added it to the top of the agenda

trask avatar Aug 18 '23 15:08 trask

Hi, @bputt-e is there any update about the pr? We would love to use youre open telemetry Nifi processor.

benhason1 avatar Nov 07 '23 13:11 benhason1

@benhason1 we're prob about 3 - 4 weeks away from getting approval to release the source code, which even then, we'll need some help from OTEL on fixing the build for older versions of nifi

bputt-e avatar Nov 07 '23 16:11 bputt-e

@bputt-e did you though on using the provenance log to achieve the same goal?

Doron-Bargo avatar Nov 09 '23 08:11 Doron-Bargo

@Doron-Bargo we didn't want to force people to turn on provenance in order to achieve tracing, plus we wanted to ensure tracing propagated from nifi to nifi and/or nifi to http/kafka/jms/etc... using the traceparent header

bputt-e avatar Nov 15 '23 00:11 bputt-e

Amazing @bputt-e are we still in the previous timelines - around 2 weeks from now?

Doron-Bargo avatar Nov 19 '23 09:11 Doron-Bargo

@Doron-Bargo yes, just waiting on approval to release

bputt-e avatar Nov 20 '23 19:11 bputt-e

Thanks is there a pr for it? So we can follow

Doron-Bargo avatar Nov 26 '23 19:11 Doron-Bargo

@Doron-Bargo nope, can't release code until we get approval

bputt-e avatar Nov 29 '23 19:11 bputt-e

A bit late to the party but just in case this is still relevant: https://github.com/galbash/otel-nifi-extension (version 1.22.0)

galbash avatar Jun 30 '24 15:06 galbash

A bit late to the party but just in case this is still relevant: https://github.com/galbash/otel-nifi-extension (version 1.22.0)

This would be great in the nifi core as a configured service

fuzolan avatar Jul 01 '24 07:07 fuzolan

Since there has been no activity on this enhancement for the past year we are closing it to help maintain our backlog. Anyone who would like to work on it is still welcome to do so, and we can re-open it at that time.

github-actions[bot] avatar Sep 30 '25 09:09 github-actions[bot]