opentelemetry-java-contrib icon indicating copy to clipboard operation
opentelemetry-java-contrib copied to clipboard
verified publisher icon open-telemetry

[Maven Extension] Migrate from plexus to JSR dependency injection

Open anuraaga opened this issue 4 years ago • 2 comments

We currently use plexus dependency injection, but using JSR would allow constructor injection, fitting better with our general patterns of non-null final fields, and provide an experience more consistent with standard frameworks.

https://maven.apache.org/maven-jsr330.html

anuraaga avatar Dec 16 '21 05:12 anuraaga

I tried to use @Inject rather than Plexus but I faced limitations with @Inject. I forgot what were these limitations, I have to look at the history of commits.

cyrille-leclerc avatar Dec 20 '21 12:12 cyrille-leclerc

For the record, I reverted from JSR-330 / SISU to Plexus on commit https://github.com/elastic/opentelemetry-maven-extension/commit/39e2975f14d1f8f1e231d6699d8da314b00331a4 .

FYI The Maven community is interested in understanding the limitations we faced: https://lists.apache.org/thread/bqm4zpjmvhmtqxjnz5qbp2yjxk9y9472

cyrille-leclerc avatar Jan 03 '22 11:01 cyrille-leclerc