opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

Add integration tests for single-core machines

Open jsuereth opened this issue 5 years ago • 5 comments

Is your feature request related to a problem? It's possible that the C++ API is used on single-core machines. If we don't test our code on single core, it's possible we use threading primitives that require multi-core to make progress, e.g spin-locks.

Describe the solution you'd like We should at a minimum KNOW if we support single-core machines via running integration tests against them. It could be we explicitly decide not to support single-core usage, but we should at least know the status.

Describe alternatives you've considered Have not considered alternatives.

Additional context N/A

jsuereth avatar Oct 12 '20 20:10 jsuereth

@jsuereth - is this something we can run on GitHub Action - Linux image, with --cpus=1 option? This may cover Linux, but not Windows nor Mac.

maxgolov avatar Dec 01 '20 01:12 maxgolov

I think just using --cpus=1 on Linux is probably fine for now. I"ll add that in a PR after the updated spin-lock (#415) goes through

jsuereth avatar Dec 03 '20 15:12 jsuereth

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

github-actions[bot] avatar Nov 24 '21 01:11 github-actions[bot]

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

github-actions[bot] avatar Jan 24 '22 01:01 github-actions[bot]

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

github-actions[bot] avatar Mar 26 '22 02:03 github-actions[bot]