opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

Fixes span creation benchmark issue #1612.

Open marcalff opened this issue 3 years ago • 1 comments

Fixes #1612

Changes

The sampler parameter was ignored in benchmark span creation test.

Now BM_NoopSpanCreation() uses the always off sampler, measuring the Noop creation code.

  • [ ] CHANGELOG.md updated for non-trivial changes
  • [ ] Unit tests have been added
  • [ ] Changes in public API reviewed

marcalff avatar Sep 20 '22 19:09 marcalff

Codecov Report

Merging #1622 (a6dd380) into main (85b7878) will decrease coverage by 0.07%. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
- Coverage   85.12%   85.06%   -0.06%     
==========================================
  Files         159      159              
  Lines        4999     4999              
==========================================
- Hits         4255     4252       -3     
- Misses        744      747       +3     
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) :arrow_down:

codecov[bot] avatar Sep 20 '22 19:09 codecov[bot]