OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

Fix#5920: Expose `hostPort` field for some services

Open nahuelverdugo opened this issue 3 years ago • 3 comments

Describe your changes :

Added an interface that let expose fields for some services connection config objects when calling the API. For example: if we request a Looker service, the only parameter from the connection that we will be able to see will be the hostPort if we are not admins.

Type of change :

  • [x] Improvement
  • [x] New feature

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [x] All new and existing tests passed.

Reviewers

Backend: @open-metadata/backend

nahuelverdugo avatar Aug 10 '22 08:08 nahuelverdugo

Schema Change Detected. Needs ingestion-core version bump

Please run make core_bump_version_dev in the project's root and commit the changes to _version.py in this PR. Please ignore if this has been handled already.

github-actions[bot] avatar Aug 10 '22 08:08 github-actions[bot]



Test summary

52 0 15 0


Run details

Project openmetadata
Status Passed
Commit 6d2f2ab2e4
Started Aug 16, 2022 5:38 AM
Ended Aug 16, 2022 5:49 AM
Duration 10:21 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 10 '22 09:08 cypress[bot]

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR. You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions[bot] avatar Aug 16 '22 05:08 github-actions[bot]

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 16 '22 05:08 sonarqubecloud[bot]

[OpenMetadata-catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 8 Code Smells

24.2% 24.2% Coverage
6.4% 6.4% Duplication

sonarqubecloud[bot] avatar Aug 16 '22 06:08 sonarqubecloud[bot]