OpenMetadata
OpenMetadata copied to clipboard
Minor: Fix user details page bugs
I worked on the following:
- [x] Fix the user avatar not showing any letter when the displayName is an empty string
- [x] Changed the patch request payload for displayName change to remove the displayName field if case of empty input instead of sending an empty string.
Before:
https://github.com/open-metadata/OpenMetadata/assets/51777795/09b96838-30ec-4d97-bc3e-272587f1f411
After:
https://github.com/open-metadata/OpenMetadata/assets/51777795/3fe8a0e2-826c-4ff1-9df1-045b74629dd4
Type of change:
- [x] Bug fix
- [x] Improvement
Checklist:
- [x] I have read the CONTRIBUTING document.
- [ ] My PR title is
Fixes <issue-number>: <short explanation> - [ ] I have commented on my code, particularly in hard-to-understand areas.
- [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
Jest test Coverage
UI tests summary
| Lines | Statements | Branches | Functions |
|---|---|---|---|
| 65.22% (35327/54167) | 42% (13974/33274) | 44.01% (4338/9856) |
Passing run #34525 ↗︎
Details:
| Merge branch 'main' into fix-user-page-bug | |||
| Project: openmetadata | Commit: 2c4c315e60 |
||
| Status: Passed | Duration: 26:33 💡 | ||
| Started: Jun 27, 2024 7:11 AM | Ended: Jun 27, 2024 8:37 AM | ||
Review all test suite changes for PR #16358 ↗︎
@Sachin-chaurasiya I've pushed the changes. Can you please review it again?
Quality Gate passed for 'open-metadata-ui'
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code