OpenMetadata icon indicating copy to clipboard operation
OpenMetadata copied to clipboard

supported cypress for team and glossary drag and drop functionality

Open Ashish8689 opened this issue 1 year ago • 3 comments

Describe your changes:

Fixes #14893

Team

  • added cypress for team drag and drop functionality
  • added droppable style in the table while dragging.
  • supported parent team level drop, through dropping on table header.
  • added restrictions on team transfer based on team type

Restricted Drop :

  • Any type drop-in Group is not allowed
  • BusinessUnit drop-in Division is not allowed
  • BusinessUnit drop-in Department is not allowed
  • Division drop-in Department is not allowed

Glossary :

  • Term level drag and drop
  • Table level drag and drop

SearchIndexApplication

  • Also fixes SearchIndexApplication cypress failure.

https://github.com/open-metadata/OpenMetadata/assets/66266464/a5c09c76-ec66-4510-b0ec-b7f102430b5e

https://github.com/open-metadata/OpenMetadata/assets/66266464/3fc008f9-23ae-4703-80d2-2afd8284cc0a

Type of change:

  • [ ] Bug fix
  • [x] Improvement
  • [ ] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [ ] My PR title is Fixes <issue-number>: <short explanation>
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Ashish8689 avatar Feb 16 '24 08:02 Ashish8689

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
61.54% (31426/51070) 40.46% (12506/30907) 40.9% (3864/9447)

github-actions[bot] avatar Feb 16 '24 08:02 github-actions[bot]

5 failed tests on run #33185 ↗︎

5 715 12 0 Flakiness 0

Details:

fix the regression of import
Project: openmetadata Commit: 41f1493d1a
Status: Failed Duration: 41:26 💡
Started: Feb 19, 2024 10:39 AM Ended: Feb 19, 2024 11:20 AM
Failed  Service/ServiceIngestion.spec.ts • 3 failed tests • cypress-ci-psql-oss-7957988667-1

View Output Video

Test Artifacts
Superset Ingestion > Create & Ingest Superset service Screenshots Video
Superset Ingestion > Update schedule options and verify Screenshots Video
Superset Ingestion > Delete Superset service Screenshots Video
Failed  Pages/DataInsightSettings.spec.js • 2 failed tests • cypress-ci-psql-oss-7957988667-1

View Output Video

Test Artifacts
Data Insight settings page should work properly > Install application Screenshots Video
Data Insight settings page should work properly > Deploy & run application Screenshots Video

Review all test suite changes for PR #15213 ↗︎

cypress[bot] avatar Feb 16 '24 09:02 cypress[bot]

@chirag-madlani changes made as per comments!

Ashish8689 avatar Feb 19 '24 08:02 Ashish8689