fix: run error hook when provider returns error code
This PR
- ensures that the error hook is ran when the provider returns an error code
Related Issues
Fixes #928
Notes
saw this bug and seemed like a straightforward fix, wasn't sure if anyone has already picked it up so feel free to reject if it's already been taken on
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.26%. Comparing base (
27c9114) to head (380b177).
Additional details and impacted files
@@ Coverage Diff @@
## main #951 +/- ##
============================================
+ Coverage 94.98% 95.26% +0.28%
- Complexity 383 392 +9
============================================
Files 36 37 +1
Lines 877 887 +10
Branches 53 54 +1
============================================
+ Hits 833 845 +12
+ Misses 24 23 -1
+ Partials 20 19 -1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 95.26% <100.00%> (+0.28%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have this suggestion, otherwise looks good :)
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code