open-dis-python icon indicating copy to clipboard operation
open-dis-python copied to clipboard
verified publisher icon open-dis

Added marshalledSize to all classes

Open VovaDev opened this issue 1 year ago • 2 comments

Fixes #11.
Implemented marshalledSize for all classes (like in Java and C# implementations). You still need to manually fill pdu.length field (aka pdu.length = pdu.marshalledSize()), but at least you could do it effortlessly.
Also includes some other critical fixes (typos in FirePdu, DirectedEnergyFirePdu and ReceiverPdu variable names).

VovaDev avatar Apr 03 '24 23:04 VovaDev

@VovaDev thank-you for the proposed change.

A large change was merged today which has created a conflict in this PR. If you are still interested in proposing this change could you rebase your PR on the latest code in master to resolve the conflict.

leif81 avatar May 10 '24 02:05 leif81

I like this suggestion, and have an idea to make this easier so that the marshalled size does not need to be hardcoded. But I need to wrap up some other work on the refactoring first.

ngjunsiang avatar May 16 '24 15:05 ngjunsiang