GenAIExamples icon indicating copy to clipboard operation
GenAIExamples copied to clipboard

Export docker images tag

Open XuehaoSun opened this issue 1 year ago • 1 comments

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds new functionality)
  • [ ] Breaking change (fix or feature that would break existing design and interface)
  • [ ] Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

XuehaoSun avatar Aug 14 '24 03:08 XuehaoSun

@XuehaoSun I confirmed manifests cannot read value from environment. I will suggest to use kustomize. Here are some examples: https://github.com/kubernetes-sigs/kustomize/blob/master/examples/image.md https://stackoverflow.com/questions/60327725/changing-image-tags-and-name-with-kustomization-yaml

Another option might use "envsubst", for example "envsubst < mydeploy.yaml | kubectl apply -f -", but need to test if it works.

I suggest to separate the manifest changes to another PR.

daisy-ycguo avatar Aug 15 '24 01:08 daisy-ycguo