GenAIExamples icon indicating copy to clipboard operation
GenAIExamples copied to clipboard

MegaService Dockerfile clone GenAIComps without tag

Open gavinlichn opened this issue 1 year ago • 4 comments

GenAIExamples/ChatQnA/docker/Dockerfile: git clone https://github.com/opea-project/GenAIComps.git

that will cause version control issue.

gavinlichn avatar Aug 06 '24 07:08 gavinlichn

Hi @gavinlichn,

Do you want to check out a tag of GenAIComp for version control? This always let the user try the latest code, instead of a fixed version.

For a specific, please check out the specific tag for both GenAIComps and GenAIExamples. Does this make sense?

Thanks!

xiguiw avatar Aug 07 '24 09:08 xiguiw

Hi @gavinlichn,

Do you want to check out a tag of GenAIComp for version control? This always let the user try the latest code, instead of a fixed version.

For a specific, please check out the specific tag for both GenAIComps and GenAIExamples. Does this make sense?

Thanks!

For a tagged build or milestone, checkout a specific tag is good enough. But I think we need to consider the everyday engineering build also. Do you have any idea to handle this case also?

gavinlichn avatar Aug 07 '24 12:08 gavinlichn

But I think we need to consider the everyday engineering build also. Do you have any idea to handle this case also?

Do you mean the daily build or weekly build? For the weekly build, it is being discussing. One it is decided, there solution will be proposed.

@chensuyue Do you have any comments for these? Thanks!

xiguiw avatar Aug 08 '24 09:08 xiguiw

We have proposed a solution for this issue and will execute from v0.9 release. We will freeze all the pip deps version and image tag version instead of using the latest one. Thank you for the comments!

chensuyue avatar Aug 12 '24 03:08 chensuyue

@gavinlichn Does Suyue's proposal solve your problem?

xiguiw avatar Sep 18 '24 07:09 xiguiw

@gavinlichn Does Suyue's proposal solve your problem?

Yes, It's worked since version v0.9

gavinlichn avatar Sep 18 '24 08:09 gavinlichn