GenAIExamples icon indicating copy to clipboard operation
GenAIExamples copied to clipboard

Create Docker-compose files and other collateral that uses tagged versions versus latest

Open mkbhanda opened this issue 1 year ago • 1 comments

For stability, for comparing versions of solutions, it is important to be able to specify versioned software. When our solutions refer to "latest" images, it is a moving target.

mkbhanda avatar Aug 05 '24 15:08 mkbhanda

@ashahba Do we have docker image of released v0.7, v0.8 on docker hub?

xiguiw avatar Aug 15 '24 09:08 xiguiw

Yes, please! Can we please ensure new versions of containers get pushed to Docker Hub with both a vX.Y release and the latest labels. That would allow us to pass the $TAG variable and lock in versions.

lucasmelogithub avatar Aug 30 '24 17:08 lucasmelogithub

@mkbhanda There is TAG in docker compose file to set the version (line 26 in the following exampes). It is latest by default (without set TAG). TAG could be set the docker image version, 1.1, 1.2 etc.

25   llm:
26     image: ${REGISTRY:-opea}/llm-textgen:${TAG:-latest}
 27     container_name: llm-textgen-server
 28     depends_on:
 29       tgi-service:
 30         condition: service_healthy
 31     ports:
 32       - "9000:9000"
 33     ipc: host
 34     environment:
 35       no_proxy: ${no_proxy}
 36       http_proxy: ${http_proxy}
 37       https_proxy: ${https_proxy}
 38       LLM_ENDPOINT: ${TGI_LLM_ENDPOINT}
 39       LLM_MODEL_ID: ${LLM_MODEL_ID}
 40       HUGGINGFACEHUB_API_TOKEN: ${HUGGINGFACEHUB_API_TOKEN}
 41       HF_TOKEN: ${HUGGINGFACEHUB_API_TOKEN}
 42     restart: unless-stopped

xiguiw avatar Mar 03 '25 13:03 xiguiw

@mkbhanda @lucasmelogithub Could we close this ticket?

xiguiw avatar Mar 03 '25 13:03 xiguiw

Yes, this has been resolved, versioning is now being used.

lucasmelogithub avatar Mar 03 '25 15:03 lucasmelogithub

Thank you for the PR and closing the issue!

mkbhanda avatar Mar 07 '25 09:03 mkbhanda