GenAIExamples icon indicating copy to clipboard operation
GenAIExamples copied to clipboard

Added role checks in data source

Open jaswanth8888 opened this issue 1 year ago • 5 comments

Description

  • Added role checks in data source
  • Users with admin role can upload, delete documents
  • user with user role can only view the existing file

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds new functionality)
  • [ ] Breaking change (fix or feature that would break existing design and interface)
  • [ ] Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

jaswanth8888 avatar Nov 08 '24 05:11 jaswanth8888

Please check the CI issue, can you pass the test locally?

chensuyue avatar Nov 14 '24 03:11 chensuyue

@jaswanth8888

This feature is useful. Are you still working on this?

xiguiw avatar Dec 23 '24 03:12 xiguiw

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

github-actions[bot] avatar Dec 23 '24 03:12 github-actions[bot]

Known issue: https://github.com/opea-project/GenAIExamples/issues/1270

chensuyue avatar Dec 24 '24 06:12 chensuyue

Known issue: #1270 1270: Let's wait for langserve 0.3.1 pypi release. https://pypi.org/project/langserve/#history

Now 1270 is released. Rerun CI to check now.

xiguiw avatar Feb 25 '25 07:02 xiguiw