Cancel API calls when unmounting components

[sarathms]

Components which initiate network calls to API server should cancel requests in progress if having to unmount unexpectedly.

Use the cancelToken feature in axios to achieve this.

Components like WebsitesSection, NetworkPropertiesSection etc.

[hellais]

Is this the same as: https://github.com/ooni/explorer/issues/20 or is it something different?

[sarathms]

They are related but not the same. I opened this as a general best practice to cancel requests started by components which are about to unmount from the DOM tree.

[hellais]

Tentatively put it in next cycle. @sarathms can you add an effort estimate to it?

[sarathms]

This effort should be merged with and done when implementing switching all API calls using swr.