Kenichi Omichi
Kenichi Omichi
I much prefer this idea to avoid typo-fixing pull requests anymore :satisfied:
FYI: kubernetes/kubernetes repo contains a script to do that as https://github.com/kubernetes/kubernetes/blob/44a0b4e145b3cafb3720119f5a3b6dd8c6e48ea4/hack/verify-spelling.sh
> but in old versions of kubespray i can do it. now i dont know what upgrade in playbooks or something and not longer work :( That could succeed accidentally....
Hi @samuelbernardolip What happens if changing modules/compute/main.tf like ``` --- a/contrib/terraform/openstack/modules/compute/main.tf +++ b/contrib/terraform/openstack/modules/compute/main.tf @@ -172,7 +172,7 @@ locals { # bastion groups bastion_sec_groups = compact(concat([ openstack_networking_secgroup_v2.k8s.id, - openstack_networking_secgroup_v2.bastion[0].id, + openstack_networking_secgroup_v2.bastion[count.index].id,...
> @oomichi Thank you for your quick answer. I'm going to test that patch during this week. Sorry for my delay. No problem, if you have some result please share...
Nice work! /ok-to-test /approve
Thank you so much for preparing a new release @floryut ! The above release-note seems good for me. +1
> I hope this calico typo correction commit will also be included in the next release! > > * [Fix typos in calico #9327](https://github.com/kubernetes-sigs/kubespray/pull/9327) That makes the parameter name change...
I guess https://github.com/kubernetes-sigs/kubespray/pull/9244 which has been merged recently fixes this issue. /cc @oomichi