Tiny Improvement?

Open owengalenjones opened this issue 9 years ago • 4 comments

Working through these, I noticed in challenge 3-1 there's two functions interpose-space and interpose-pipe. It was odd seeing two specific fn's so soon after learning about generalized fn's with :onyx/params. Not sure if it's useful but seems like it could reinforce best-(?)-practices.

Feb 21 '17 23:02 owengalenjones

I like that idea a lot! Something like interpose-character instead?

Feb 22 '17 00:02 gardnervickers

Yep! I can draft a PR if you want, just wanted to confirm whether or not this would actually be an improvement first :)

Feb 22 '17 00:02 owengalenjones

@owengalenjones Sure, thanks! 👍

Feb 22 '17 00:02 MichaelDrogalis

@MichaelDrogalis whats up Mike :)

Feb 22 '17 01:02 owengalenjones