What's the model name convention?

[mszhanyi]

Ask a Question

Question

Could we remove some characters in the model name.

1. model name contains whitespace https://github.com/onnx/models/blob/e4aa511d91cc4b64f156beb950701b8c744d86a7/ONNX_HUB_MANIFEST.json#L6693
2. model name contains Parentheses https://github.com/onnx/models/blob/e4aa511d91cc4b64f156beb950701b8c744d86a7/ONNX_HUB_MANIFEST.json#L6758
3. model name contains dot https://github.com/onnx/models/blob/e4aa511d91cc4b64f156beb950701b8c744d86a7/ONNX_HUB_MANIFEST.json#L4903

[jcwchen]

Hi @mszhanyi, Good question. I don't think ONNX Model Zoo requires a strict naming convention. Even in the example template, it uses "VGG 19" as an example with a space in the model name. I went through the whole repo and found that actually space, dot, Parentheses in the model name are widely-used...

I think it's hard for us to remove all existing space,parentheses,dot in the model name promptly because users might have already used onnx.hub to download models with previous name. We might need to announce in the community saying that the naming change will be applied in the future. For now, at least going forward ONNX Model can require new-added models to have stricter naming convention.

May I understand why you need this change? If loading/saving a model with the original model name in filesystem is a trouble, perhaps use the name from model_path in ONNX_HUB_MANIFEST.json instead.