nft-storefront
nft-storefront copied to clipboard
onflow
A general-purpose Cadence contract for trading NFTs on Flow
Closes: #87 This PR targets the existing `stable-cadence` branch, so includes some updates from main. The idea is to use `stable-cadence` as the working Stable Cadence branch moving forward. Dependencies...
## Description NFTStorefront contract and accompanying transactions/scripts need to be updated for Cadence 1.0.
- bump fcl-testing-js to v0.4.0 - matching uint64 values using quoted number
## Description NFTStorefrontV2 contract and accompanying transactions/scripts need to be updated for Cadence 1.0.
1. Currently, we have a `borrowNFT()` function for Listing. It would be great if we could also have a `borrowNFTSafe()` function. 2. Please add a `borrowViewResolver()` function to Listing. This...
### Current Behavior ```cadence /// hasListingBecomeGhosted /// Tells whether listed NFT is present in provided capability. /// If it returns `false` then it means listing becomes ghost or sold out....
In order to make sense of the ever increasing premutations of listings/offers/swaps etc I propose that we introduce a new view called **Listing** and that said view is exposed from...
# Context In current implementation, Royalties are fetched and add as the sale cut within the transaction code. However, consumers of the NFTStorefrontV2 like marketplaces or third party apps have...
I've noticed a specific version of Cadence is used in tests. Why not use the latest? ``` run: sh -ci "$(curl -fsSL https://raw.githubusercontent.com/onflow/flow-cli/master/install.sh)" -- v0.33.1-sc-m5 ``` The issue with fixing...
The `sell_item_via_catalog` tx here https://github.com/onflow/nft-storefront/blob/main/transactions/sell_item_via_catalog.cdc looks a bit confusing. On [line 39](https://github.com/onflow/nft-storefront/blob/78e6df21959cc872569a54c6a232b603c622955e/transactions/sell_item_via_catalog.cdc#L38) it specifies a private path for capability by ``` // We need a provider capability, but one is...
