flow-jvm-sdk icon indicating copy to clipboard operation
flow-jvm-sdk copied to clipboard

#110/ CollectionGuarantee type differs from protobuf schema

Open lealobanov opened this issue 1 year ago • 4 comments

Closes: #110

Description

  • Update fields for FlowCollectionGuarantee model: https://github.com/onflow/flow/blob/master/protobuf/flow/entities/collection.proto#L13
  • Did not add signer_ids as it has been deprecated
  • Update related tests with new fields

For contributor use:

  • [ ] Targeted PR against master branch
  • [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • [ ] Code follows the standards mentioned here.
  • [ ] Updated relevant documentation
  • [ ] Re-reviewed Files changed in the Github PR explorer
  • [ ] Added appropriate labels

lealobanov avatar Oct 09 '24 10:10 lealobanov

Unit Test Results

0 files   -   54  0 suites   - 54   0s :stopwatch: -23s 0 tests  - 316  0 :heavy_check_mark:  - 316  0 :zzz: ±0  0 :x: ±0 

Results for commit 11f2ad52. ± Comparison against base commit f8afbfb3.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 09 '24 10:10 github-actions[bot]

Integration Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 11f2ad52. ± Comparison against base commit f8afbfb3.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 09 '24 10:10 github-actions[bot]

SDK Examples Unit Test Results

37 files  ±0  37 suites  ±0   6m 14s :stopwatch: -5s 70 tests ±0  69 :heavy_check_mark:  - 1  0 :zzz: ±0  1 :x: +1 

For more details on these failures, see this check.

Results for commit fbd0e879. ± Comparison against base commit f8afbfb3.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 09 '24 10:10 github-actions[bot]

Common Integration Test Results

0 files   - 1  0 suites   - 1   0s :stopwatch: -7s 0 tests  - 1  0 :heavy_check_mark:  - 1  0 :zzz: ±0  0 :x: ±0 

Results for commit fbd0e879. ± Comparison against base commit f8afbfb3.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 09 '24 10:10 github-actions[bot]