ubi_reader icon indicating copy to clipboard operation
ubi_reader copied to clipboard

ONEKEY baseline

Open qkaiser opened this issue 2 years ago • 2 comments

Draft branch to establish a baseline for code quality and probably do some refactoring as mentioned in https://github.com/onekey-sec/ubi_reader/discussions/75

qkaiser avatar May 13 '23 12:05 qkaiser

Not sure if this is the correct place to comment on this, but this looks like a cleanup and I thought it might fit. :)

The pyproject.toml (or the setup.py before) is very vague with license = "GNU GPL".

I found the following indicators:

  • LICENSE file is GPL-3.0
  • ubireader/ubi/defines.py: GPL-2.0-or-later
  • ubireader/ubifs/defines.py: GPL-2.0 (without clarification for "-only" or "-or-later")
  • all other non-empty python files had a GPL-3.0-or-later header

tnias avatar Jun 19 '23 23:06 tnias

@tnias makes sense, thanks for pointing it out

qkaiser avatar Jun 20 '23 12:06 qkaiser