oneTBB icon indicating copy to clipboard operation
oneTBB copied to clipboard

Upstream changes from local DocTest source code to the origin repository

Open ivankochin opened this issue 4 years ago • 2 comments

Now the DocTest is updated to the latest version (2.4.6) but it still has several local fixes that were not upstreamed to the origin repository. This should be done to simplify the future DocTestupdating process. Here is the list of local changes with the comments:

Possibly already fixed in the origin repo issues (dev branch):

  • [x] Fix copy elision absence case - (https://github.com/onqtam/doctest/pull/516)
  • [x] Implement old version of check due to Intel Compiler internal error: assertion failed at: "shared/cfe/edgcpfe/exprutil.c", line 5155 -(https://github.com/onqtam/doctest/pull/523)
  • [x] Fix the typo (word "degrade") - (https://github.com/onqtam/doctest/pull/546)

Fixes that have the corresponding PR to the origin repo:

  • [X] list_query_results() was declared but never referenced - (https://github.com/onqtam/doctest/pull/550)

Fixes that may be upstreamed without additional actuality check:

  • [x] Universal Windows Platform support - (https://github.com/doctest/doctest/pull/558)

Fixes that should be reviewed before the upstreaming:

  • [x] Intel Compiler support
    • [x] Work-around for the warning: 'routine is both "inline" and "noinline"'
  • [x] missing initializer for member - (https://github.com/doctest/doctest/pull/556)
  • [ ] Due to race between exiting the process and starting of a new detached thread in Windows, thread local variables, which constructors or destructors have calls to runtime functions (e.g. free() function) can cause access violation since TBB along with runtime library may have been unloaded by the time these variables are constructed or destroyed.
  • [x] DOCTEST_ANONYMOUS doesn't work on the same line here on MSVS 15.9.13 - (https://github.com/doctest/doctest/pull/556)

All the changes listed above are marked inside our local DocTest source code by the "TODO: upstream the change to doctest : ..." comments.

ivankochin avatar Nov 09 '21 09:11 ivankochin

@ivankochin is this issue still relevant?

nofuturre avatar Jul 09 '24 06:07 nofuturre

@nofuturre It is. We are still applying workarounds to doctest while doing updates. But I think we need to check if is there any issues with the latest version.

isaevil avatar Jul 09 '24 08:07 isaevil