oneDPL icon indicating copy to clipboard operation
oneDPL copied to clipboard

Extend RFC announcement to include discussions

Open timmiesmith opened this issue 1 year ago • 2 comments

The PR updates the action that currently announces PR labeled as RFC to the oneDPL Slack channel to include discussions labeled as RFC as well.

timmiesmith avatar Jul 30 '24 19:07 timmiesmith

I'm using https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#discussion to identify the keywords needed.

timmiesmith avatar Jul 30 '24 19:07 timmiesmith

It looks like the action checks github.event.pull_request.labels.*.name, for RFC, but is this the same variable we should be checking for discussions as well? I assume we need a second check or to modify this one to cover github.event.discussion.labels.*.name (guessing the formulation of this).

danhoeflinger avatar Jul 30 '24 20:07 danhoeflinger

goofed the rebase. I'm closing this PR and will open another.

timmiesmith avatar Jun 09 '25 22:06 timmiesmith