oneDNN icon indicating copy to clipboard operation
oneDNN copied to clipboard

generic: sycl: Skip all tests that use block format for generic backend

Open s-Nick opened this issue 7 months ago • 4 comments

Description

Generic backend doesn't support block format. This PR implement a skip function to check if the format tag and skip the test in case of generic backend.

Checklist

General

  • [x] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • [x] Have you formatted the code using clang-format?

s-Nick avatar Jun 27 '25 09:06 s-Nick

make test disable test_device_cpu enable build_vendor_generic enable arch_gpu_xe-hpc enable compiler_icx-oss

s-Nick avatar Jun 27 '25 09:06 s-Nick

@dzarukin, does this change look right to you?

vpirogov avatar Jul 09 '25 17:07 vpirogov

@dzarukin, does this change look right to you?

I was about to post a message that was not the agreement when the reorder change landed, but we may have more lists where specific blocked tags are called out, so I didn't.

However, this change won't help to decrease the amount of CI failures as we are not using blocked tags in ci lists, so I don't see why this is more important than changes that are exposed on day-to-day basis.

dzarukin avatar Jul 09 '25 17:07 dzarukin

@uxlfoundation/onednn-arch we discussed this PR should be good to do.

Rbiessy avatar Jul 21 '25 13:07 Rbiessy