oneDNN icon indicating copy to clipboard operation
oneDNN copied to clipboard

[GPU] Expand matmul decomp cases

Open kealan-barbieri opened this issue 10 months ago • 7 comments

Description

Expands cases where inputs are decompressed to include integer activations as well as weights. Integer weights are still required but in the presence of fpmath setting activations will also be upconverted.

This means that cases intending to use integer accumulation must not supply eg attr-fpmath=f16:true as all such cases must be upconverted per https://jira.devtools.intel.com/browse/MFDNN-13380.

Align behavior with doc for application of fpmath to integer inputs, if integer fpmath is true then upconversion must occur, this changes the strategy selection. Relabel strategies that perform upconversion to make them explicit. Update strategy selection to distinguish ordering between different "compound" types eg "[OH]" "[OB]".

Fixes # (github issue)

Checklist

General

  • [x] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • [x] Have you formatted the code using clang-format?

kealan-barbieri avatar Mar 18 '25 22:03 kealan-barbieri

make test disable device_cpu enable device_gpu disable benchdnn_all enable benchdnn_matmul

kealan-barbieri avatar Mar 24 '25 22:03 kealan-barbieri

make test disable device_cpu enable device_gpu disable benchdnn_all enable benchdnn_matmul

kealan-barbieri avatar Mar 27 '25 18:03 kealan-barbieri

make test disable device_cpu enable device_gpu disable benchdnn_all enable benchdnn_matmul enable benchdnn_ip

kealan-barbieri avatar Mar 28 '25 01:03 kealan-barbieri

make test disable device_cpu enable device_gpu disable benchdnn_all enable benchdnn_matmul enable benchdnn_ip

kealan-barbieri avatar Apr 02 '25 06:04 kealan-barbieri

make test perf-gpu set primitive=matmul

kealan-barbieri avatar Apr 15 '25 21:04 kealan-barbieri

make test perf-gpu set primitive=matmul

kealan-barbieri avatar May 09 '25 16:05 kealan-barbieri

make test perf-gpu set primitive=matmul

kealan-barbieri avatar May 12 '25 17:05 kealan-barbieri

rendered unnecessary.

kealan-barbieri avatar Sep 17 '25 21:09 kealan-barbieri