oneDNN icon indicating copy to clipboard operation
oneDNN copied to clipboard

cpu: aarch64: Extend ARM SVE Support for BRGEMM General and 1x1 Forward Convolution.

Open kasturedeeksha opened this issue 1 year ago • 1 comments

Description

This commit enables BRGEMM general and 1x1 forward convolution for the ARM SVE ISA.

Major code changes:

Added BRGEMM convolution files in src/aarch64 to support general and 1x1 forward convolution. Added support for brgemm convolution in src/cpu/aarch64/brgemm/brgemm_containers.hpp, src/aarch64/cpu_isa_traits.hpp and src/cpu/aarch64/jit_primitive_conf.hpp.

Checklist

General

  • [x] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit? Test output is same with and without this commit.
  1. make test output :
 98% tests passed, 3 tests failed out of 194
  Total Test time (real) = 535.50 sec
  The following tests FAILED:
      148 - test_graph_unit_dnnl_conv_usm_cpu (Failed)
      153 - test_graph_unit_dnnl_large_partition_usm_cpu (Failed)
      175 - test_benchdnn_modeC_graph_ci_cpu (Failed)
 Errors while running CTest
 Output from these tests are in: 
 /home/deekshak/xybak/oss_pr/forked_oss/oneDNN_Fork/build/Testing/Temporary/LastTest.log
 Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
 make: *** [Makefile:71: test] Error 8
  • [x] Have you formatted the code using clang-format? Yes cc: @kawakami-k

kasturedeeksha avatar Jun 19 '24 08:06 kasturedeeksha

@vpirogov , Hello Could you please support for the review of this PR In case there is any comment from your side kindly let us know so that we can proceed further for merger as well.

abhijain1204fujitsu avatar Jun 24 '24 08:06 abhijain1204fujitsu

Thank you for the contribution.

dzarukin avatar Jul 03 '24 05:07 dzarukin