oneDNN icon indicating copy to clipboard operation
oneDNN copied to clipboard
verified publisher icon oneapi-src

[ACL] Potentially redundant check in `acl_init_conf`

Open alvoron opened this issue 1 year ago • 1 comments

What is the reason of having such check? https://github.com/oneapi-src/oneDNN/blob/49a1dcd620b2e728f1cee4f44c9a827a0f720411/src/cpu/aarch64/acl_convolution_utils.cpp#L110-L111

If this condition is true and it does not return status::unimplemented then arm_compute::NEDepthwiseConvolutionLayer::validate will pass successfully later in init_conf_depthwise method.

Does it mean that ACL's NEDepthwiseConvolutionLayer could handle the case is_depthwise && (t_pad >= kh || b_pad >= kh || l_pad >= kw || r_pad >= kw) and this check is not required?

cc @milpuz01 @jondea

alvoron avatar Feb 15 '24 14:02 alvoron

The check has been added by ACL team: https://github.com/oneapi-src/oneDNN/pull/1664 I'm discussing the issue with @milpuz01 trying to reproduce the initial issue.

alvoron avatar Feb 19 '24 17:02 alvoron