oneDNN icon indicating copy to clipboard operation
oneDNN copied to clipboard

rfc: support implicit concat

Open dzarukin opened this issue 4 years ago • 2 comments

This RFC covers oneDNN vision on implicit concat support on user side, provides an example how it may be implemented and potential challenges to implement it.

Link to rendered document.

dzarukin avatar Dec 04 '21 00:12 dzarukin

@dzarukin, have you shared the PoC to estimate the performance gain we can get?

densamoilov avatar Dec 07 '21 21:12 densamoilov

@dzarukin, have you shared the PoC to estimate the performance gain we can get?

Discussed offline. I'll post if/once I get any interesting data.

dzarukin avatar Dec 08 '21 04:12 dzarukin

Promote this RFC for the purpose of documenting the approach since this will likely be the way to go - use concat primitive to get descriptors and re-create original primitive descriptors to make an implicit concat approach. What's not covered in the library:

  • CPU backend (entirely), including reorder.
  • Validation. Benchdnn doesn't work with submemory at all. This is likely a discussion for further RFC once this direction gets priority back again.

dzarukin avatar May 08 '23 19:05 dzarukin